Add transient failure retry to SharedConcurrencyLimitTest
#7591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SharedConcurrencyLimitTest
has been extremely flaky recently. The issue appears to be from the fact that:To fix it, add retry to our API calls in these tests when it appears that the process has failed its liveliness check. For now I've only introduced this retry logic to
EgressTests
. If we find other tests are facing this same issue we can consider moving this retry logic further down inside of our api client.Alternatively, the new pruning algorithm in listen mode should prevent this issue. Once it's out of its experimental phase, we can consider moving these tests over to
Listen
mode to leverage the new algorithm and removing the retries.Release Notes Entry