Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transient failure retry to SharedConcurrencyLimitTest #7591

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

schmittjoseph
Copy link
Member

Summary

SharedConcurrencyLimitTest has been extremely flaky recently. The issue appears to be from the fact that:

  1. We're running on a resource constrained system.
  2. This test runs multiple concurrent traces (3), while also triggering cancellations. This is somewhat intensive inside the test environment.
  3. Because of the above 2 reasons, the test app fails its responsiveness check (in Connect mode, taking longer than 3 seconds to respond) when doing additional API calls, causing a test failure.

To fix it, add retry to our API calls in these tests when it appears that the process has failed its liveliness check. For now I've only introduced this retry logic to EgressTests. If we find other tests are facing this same issue we can consider moving this retry logic further down inside of our api client.

Alternatively, the new pruning algorithm in listen mode should prevent this issue. Once it's out of its experimental phase, we can consider moving these tests over to Listen mode to leverage the new algorithm and removing the retries.

Release Notes Entry

@schmittjoseph schmittjoseph requested a review from a team as a code owner November 1, 2024 16:41
@schmittjoseph schmittjoseph merged commit 5c9e7f1 into dotnet:main Nov 1, 2024
26 checks passed
@schmittjoseph
Copy link
Member Author

/backport to release/8.0

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Started backporting to release/8.0: https://github.com/dotnet/dotnet-monitor/actions/runs/11713810934

github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
schmittjoseph added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants